fix(install.sh): guard rm -rf against empty SKILLS_DIR (SC2115)#72
Conversation
Defense-in-depth against an empty SKILLS_DIR expanding to a root-level path. Empty values are already rejected upstream; this makes it impossible by construction. One-char change, behavior otherwise identical.
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
What
Hardens the
rm -rfininstall.shper CodeRabbit / shellcheck SC2115:Why
Defense-in-depth: if
SKILLS_DIRwere ever empty, the old form expands torm -rf "/${name}"(a root-level path). The empty case is already blocked upstream (empty--dirandSKILLS_DIRare rejected/defaulted), so this can't trigger today — but${SKILLS_DIR:?}makes it impossible by construction and silences the shellcheck warning. One-character change; behavior is otherwise identical.Follow-up to the review on #71.
🤖 Generated with Claude Code